Amarissa O. answered 06/27/19
Supportive and Relational Outlook on Tutoring
This is probably not the answer you're hoping to hear, but these sort of questions are subjective and up to taste. However, on a more practical level, I would encourage you to get your story peer reviewed and see how people react to how your writing. I think that's the only way to gauge effectiveness of your storytelling elements. I know from experience that it's vulnerable and delicate to let someone else read an unfinished story, especially when you have a really intense inner critic. It's like handing people your beating heart and hoping they don't step on it.
Back to the point on dialog, here's some of the best advice I've been given:
-Dialog is rarely effective when characters says exactly what they think or feel.
-The exception to the point above is in the case of an argument. An argument is a great way to get information out.
-Silence and actions communicate. Having your character kick a garbage can is more effective than him exclaim that he's very angry.
I hope some of that helps! The last thing I would say is to join a writing group. Reading other people's writing can be a really effective way of seeing why certain things work and don't work. It's also nice to have a safe and consistent community that sticks with you as the story develops.