This is a limiting reactant problem. We need the reaction:
Zn + 2HCl ⇒ ZnCl2 + H2
One of the easiest ways is the brute force of calculating g of hydrogen produced by each reactant if the other is in excess. Whichever value of grams of Hydrogen is less is the answer and you also know the limiting reactant.
25.0 g Zn(1 mole/65.38 g Zn)(1 mole H2/ 1 mole Zn)(2.016 g/mole H2) =
1855 ml(1 liter/1000 ml)(.25 mole HCl/liter)(1 H2/2 HCl)(2.016 g/mole H2) =
I'll leave the calculation to you.
Please consider a tutor.